[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use common linker script for all i386-pc systems

From: Pavel Roskin
Subject: Re: [PATCH] Use common linker script for all i386-pc systems
Date: Tue, 19 May 2009 16:13:12 -0400
User-agent: Internet Messaging Program (IMP) H3 (4.1.4)

Quoting Christian Franke <address@hidden>:

Good idea. Patch works on Cygwin. Does it work on Linux, FreeBSD, ... ?

It works on Linux.  I assume it should work on every OS that has GNU ld.

The variable TARGET_IMG_LDFLAGS_AC can also be removed, see attached patch.

I think we can do a big cleanup. The start address could be specified in the linker script. Some tests will become unnecessary. We should be able to move a lot of code from the configure script into the makefiles.

+/* Linker script to create grub .img files on Cygwin.  */

This comment is out of sync

I know.

-       .long   END_SYMBOL
+       .long   __bss_end__

This variable isn't used at all. In my Apple's CC patch I just remove it

OK, let's remove it.

'grub_start_addr' and '.globl start, _start' are also not used.

Patches are welcome.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]