[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Eliminate incorrect check for grub_I386_CHECK_REGPARM_BU
Re: [PATCH 2/2] Eliminate incorrect check for grub_I386_CHECK_REGPARM_BUG
Fri, 22 May 2009 17:18:24 -0400
On Fri, 2009-05-22 at 00:36 -0400, Pavel Roskin wrote:
> NESTED_FUNC_ATTR is defined to "__attribute__ ((__regparm__ (1))" for
> i386 targets regardless of the outcome of the test. Since
> NESTED_FUNC_ATTR is on the way out, a better test won't be written.
> To be safe, define NESTED_FUNC_ATTR whenever we are compiling the
> specific file for i386 architecture, even the target platform is not
> i386 (i.e. compiling utilities when the host is i386 and the target is
> * aclocal.m4 (grub_I386_CHECK_REGPARM_BUG): Remove.
> * configure.ac: Don't call grub_I386_CHECK_REGPARM_BUG. Define
> NESTED_FUNC_ATTR by AH_BOTTOM. Base NESTED_FUNC_ATTR value
> solely on the compile time architecture.
I've committed this with a minor change. regparm(1) is not used for the
utilities, as they are compiled without -mregparm(3). This fixes
grub-setup on i386.
We still need to get rid of NESTED_FUNC_ATTR eventually, but the
immediate user-visible issue is resolved now.