[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: making the --no-floopy option of grub-install more descriptive

From: Pavel Roskin
Subject: Re: making the --no-floopy option of grub-install more descriptive
Date: Fri, 29 May 2009 12:27:45 -0400

On Fri, 2009-05-29 at 14:05 +0200, Felix Zielcke wrote:
> Hi,
> on a Debian bug report [0] someone complained that the --no-floppy
> option should be better documented in the man page, because it only
> works if doestn't exist or --recheck is given and he was
> confused of this.

For --no-floppy not to work, grub-install would have to probe the floppy
when --no-floppy is used.  I don't see the evidence of it happening.

> But it's generated from the --help output and I'm not that sure to make
> it longer.
> Or would something like this be okay?
> Index: util/i386/pc/
> ===================================================================
> --- util/i386/pc/      (revision 2237)
> +++ util/i386/pc/      (working copy)
> @@ -65,7 +65,8 @@ Install GRUB on your drive.
>    --grub-mkimage=FILE     use FILE as grub-mkimage
>    --grub-mkdevicemap=FILE use FILE as grub-mkdevicemap
>    --grub-probe=FILE       use FILE as grub-probe
> -  --no-floppy             do not probe any floppy drive
> +  --no-floppy             do not probe any floppy drive. Works only if
> +                 doestn't exit or --recheck is
> given

First of all, please check spelling of your patches.

Many options in many programs have effect only if some other options are
used or not used.  It's a minor technical detail.  Such details may
belong to manuals, but perhaps not at this stage of development.  In my
opinion, the whole idea of probing all hardware in the system is broken.
grub-install cannot predict how BIOS would see the devices.  So
"--no-floppy" can go away before the next stable release.

We could reverse the logic and not probe floppies by default.  But I'm
not sure it's worth the trouble.

We really need to support installation on non-probed devices.  Then we
can limit the probing to the cases when it's explicitly requested.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]