Re: [PATCH] support of hfsx ( case comparaison )

[Pavel Roskin]

On Fri, 2009-06-05 at 21:23 +0200, Michael Scherer wrote:

> Ok, I have taken in account your remark. Here is another patch.

I've applied your patch with two fixes.  Somehow you interchanged the
values of GRUB_HFSPLUSX_BINARYCOMPARE and GRUB_HFSPLUSX_CASEFOLDING.
GRUB_HFSPLUSX_BINARYCOMPARE is 0xBC and GRUB_HFSPLUSX_CASEFOLDING is
0xCF.  The values are actually abbreviations.

I wonder if you have tested your patch.  I have tested the final patch
on both case-sensitive and case-insensitive filesystems, and it appears
to be OK.

Also, it should not be needed to call an inline function from
grub_hfsplus_iterate_dir().  It's easier to calculate it once for the
filesystem at the mount time.

-- 
Regards,
Pavel Roskin