[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix SigSegV and hang with grub-emu-usb
From: |
Pavel Roskin |
Subject: |
Re: [PATCH] fix SigSegV and hang with grub-emu-usb |
Date: |
Fri, 19 Jun 2009 11:20:52 -0400 |
On Fri, 2009-06-19 at 16:58 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello when testing grub-emu with USB support I stumbled across several
> problems
> 1) compile time warning of undefined grub_usb_libinit
> 2) When launched under normal user it crashed
> 3) When launched as superuser it hanged on ls
> Here is the fix. Formatting omitted for readability
It's not clear which changes are responsible for fixing which problems.
Please post separate patches if you want a meaningful review.
Regarding the compile warning fix, I would try to make
grub_libusb_init() and grub_libusb_fini() appear in grub_emu_init.h
rather than declare them elsewhere.
--
Regards,
Pavel Roskin
- [PATCH] fix SigSegV and hang with grub-emu-usb, Vladimir 'phcoder' Serbinenko, 2009/06/19
- Re: [PATCH] fix SigSegV and hang with grub-emu-usb,
Pavel Roskin <=
- Re: [PATCH] fix SigSegV and hang with grub-emu-usb, Vladimir 'phcoder' Serbinenko, 2009/06/19
- Re: [PATCH] fix SigSegV and hang with grub-emu-usb, Pavel Roskin, 2009/06/19
- Re: [PATCH] fix SigSegV and hang with grub-emu-usb, Vladimir 'phcoder' Serbinenko, 2009/06/19
- Re: [PATCH] fix SigSegV and hang with grub-emu-usb, Vladimir 'phcoder' Serbinenko, 2009/06/19
- Re: [PATCH] fix SigSegV and hang with grub-emu-usb, Pavel Roskin, 2009/06/19
- Re: [PATCH] fix SigSegV and hang with grub-emu-usb, Vladimir 'phcoder' Serbinenko, 2009/06/19