grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] Don't put modules without dependencies into moddep.lst


From: Robert Millan
Subject: Re: [PATCH 2/3] Don't put modules without dependencies into moddep.lst
Date: Wed, 1 Jul 2009 15:10:25 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Tue, Jun 30, 2009 at 08:35:09PM -0400, Pavel Roskin wrote:
> +    if (modlist != "") {

Are you sure this does what you expect?  I read it as "compare this
char * with this const char *", which will always return false.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]