Re: [PATCH] use ljmp to reboot (Re: at_keyboard flush on i386-qemu)

[Pavel Roskin]

On Tue, 2009-07-07 at 21:51 +0200, Robert Millan wrote:

> I think we should just jump to 0xffff0 to reboot.  I didn't know back when I
> wrote reboot.c, but this is supposedly more reliable since we're jumping to
> code in ROM which hasn't been overwritten (kern/i386/pc/startup.S uses the
> same trick for its own grub_reboot()).

I have no objections about the patch except that it breaks compilation
for i386-coreboot:

kernel_img-symlist.o:(.data+0x3b4): undefined reference to `grub_reboot'

Perhaps kern/i386/reboot.c should be kept, but the code should only be
enabled for coreboot.

By the way, GRUB_MACHINE_LINUXBIOS should be renamed to
GRUB_MACHINE_COREBOOT.  Its use in loader/multiboot_loader.c is dubious.

-- 
Regards,
Pavel Roskin