Re: [PATCH] AFS fixes and improvements

[Vladimir 'phcoder' Serbinenko]

On Sun, Jul 19, 2009 at 10:47 PM, Pavel Roskin<address@hidden> wrote:
> On Sun, 2009-07-19 at 22:40 +0200, Vladimir 'phcoder' Serbinenko wrote:
>> > I prefer not to fix minor memory leaks by huge patches.  I have a patch,
>> > I just wanted to look at the possibility to use grub_kzalloc() and
>> > allocating data as part of the partition.
>> Well nested partition patch changes the way how partitions are handled
>> and fix for memory leak probably wouldn't stay long and will just
>> cause an unnecessary rediffing. I prefer to commit a big patch and
>> then look if memory leak remains and if it's the case fix the memory
>> leak
>
> I think we should release 1.97 first.  Sorry, I know that it's bad to
> sit on a pile of code, but in my opinion, the nested partition patch is
> too intrusive at this point.
>
For the release we prepared a lot of improvements for FreeBSD support.
Hopefully it will attract new FreeBSD users. Supporting nested
partitions required to abandon the syntax like (hd0,a) even if the
syntax (hd0,1,a) could be preserved. If we release 1.97 now without
nested partition patch it would be much more difficult in the future
to break the compatibility with (hd0,a) format. So I would prefer to
get nested partition patch in first before releasing 1.97
> I was planning a detailed review of that patch, but I didn't have a
> chance.
>
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git