[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Check for the appropriate condition in types.h
|
From: |
Pavel Roskin |
|
Subject: |
Re: [PATCH] Check for the appropriate condition in types.h |
|
Date: |
Thu, 23 Jul 2009 10:37:31 -0400 |
On Thu, 2009-07-23 at 13:10 +0200, Javier Martín wrote:
> Currently <grub/types.h> verifies that sizeof(void*)==sizeof(long) and
> then proceeds to define most fixed-length types based on sizeof(void*).
> While simplification seems a good idea on paper, it is always good
> practice to check specifically for what we want to know. In particular,
> the assumption that long can hold a pointer will go down when (if)
> mingw64 support is merged, because Win64 follows the LLP64 model instead
> of the LP64 *nix model.
>
> Given that currently both values are, by precondition, the same, this
> change is guaranteed not to create any problems, while it might avoid
> them in the future.
The patch is good. Please include the ChangeLog entry.
--
Regards,
Pavel Roskin
- [PATCH] Check for the appropriate condition in types.h, Javier Martín, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h,
Pavel Roskin <=
- Re: [PATCH] Check for the appropriate condition in types.h, Javier Martín, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Vladimir 'phcoder' Serbinenko, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Javier Martín, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Pavel Roskin, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Vladimir 'phcoder' Serbinenko, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Pavel Roskin, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Javier Martín, 2009/07/25