[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] Relocator framework

From: Pavel Roskin
Subject: Re: [PATCH 1/2] Relocator framework
Date: Fri, 07 Aug 2009 23:52:22 -0400

On Fri, 2009-08-07 at 14:01 +0200, Vladimir 'phcoder' Serbinenko wrote:

> Apple's compiler is based GCC but binutils aren't and they pose the
> most of problems. Actualy the most problematic bit was that I didn't
> know that unless you prefix variable with L_ apple's assembler treats
> it as global. Adding L_ in this code solves problem. Yves proposed to
> add a LOCAL(x) macro to symbol.h this way the assembler code is also
> more readable. I also did further adjustments in this patch to
> decrease the number of ifdefs but had no time to test it and so
> couldn't submit it

I would prefer if you don't commit any patches that introduce any more
preprocessor conditionals for the Apple compiler or assembler.

It would make it hard to debug problems reported by others, as different
compilers would produce different binaries.

If we are using some feature that is just nice but not needed (such as
binary & in lnxboot.S to set the image size to 1024), it would be better
to avoid using that feature for all compilers rather than for the
compilers that don't support it.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]