[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve handling of "keep" in gfxpayload

From: Robert Millan
Subject: Re: [PATCH] Improve handling of "keep" in gfxpayload
Date: Mon, 10 Aug 2009 13:49:40 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Aug 10, 2009 at 12:01:02PM +0100, Colin Watson wrote:
> If the user set "keep" in gfxpayload, as I understand it, that indicates
> that they want the graphical mode set by GRUB to persist through to the
> kernel. In order for this to actually work with Linux, we need to set up
> the vid_mode boot parameter to indicate that it should keep the current
> video mode, otherwise it'll just reset the mode to text at boot and
> nothing much is gained. This patch fixes that.

Nice catch, I wasn't aware an extra flag was needed.

> Note that I'm explicitly not enabling GRUB_ASSUME_LINUX_HAS_FB_SUPPORT
> in the Ubuntu grub2 package.

Actually, the Debian package stopped enabling it too.  I had my reservations
when "keep" was introduced, but now I see that Vladimir's idea is a much
better option than hardcoding in the binary.

I think I'll remove GRUB_ASSUME_LINUX_HAS_FB_SUPPORT.  It seems that nobody
is going to use it, so all it does is add complexity.  This will also make
your patch simpler.

Is there any objection to that?

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]