[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fwd: [PATCH 1/2] Framebuffer split

From: Vladimir 'phcoder' Serbinenko
Subject: Re: Fwd: [PATCH 1/2] Framebuffer split
Date: Mon, 10 Aug 2009 14:30:19 +0200

> As I understand it the code checks the bounds against the active
> videomode and then sets the viewport on the active render target.
> Since the active render target can be arbitrarily set by the user (to,
> say an offscreen bitmap for rendering the terminal text) I do not see
> how these two parts match.
Well this code was already there before my patch. I just restructured
it. It basically requires viewport to be legal. For offscreen
rendering use allocate_render_target
In my patch I tried not to modify the behaviour as far as possible.
Your comments about improving the design are welcome but could you
start a separate thread? If an improvement that you propose is small
in code send a patch together with proposal - it allows to speak about
something that is here rather something that could be. If it's bigger
then discuss before implementing, perhaps send a small pseudo-patch
which shows how it will be implemented. Pseudo patches don't have to
work but are just for discussion.
> Thanks
> Michal
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'phcoder' Serbinenko

Personal git repository:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]