[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFT,PATCH] Move embedding to appropriate partmap files

From: Robert Millan
Subject: Re: [RFT,PATCH] Move embedding to appropriate partmap files
Date: Wed, 12 Aug 2009 02:38:00 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello. A bug was filed that embedding code in grub-setup.c was
> ignoring partmap metadata which could cause its overwriting. To avoid
> usage of metadata and because of upcoming sunpc embedding support I
> propose to move embedding to partmap/*.c. For this I devised an
> interface which enables future reusage of embedding for other too if
> necessary.

Can this go in util/i386/pc/ instead?  This is basicaly ad-hoc code and
doesn't seem very meaningful in generic partmap/*.c.

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]