[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Disable debug messages in reiserfs.mod

From: Robert Millan
Subject: Re: [PATCH] Disable debug messages in reiserfs.mod
Date: Mon, 17 Aug 2009 15:39:53 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Sat, Aug 15, 2009 at 04:37:26PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> As you can see reiserfs.c is the only filesystem module with debugging
> information. (Now I noticed that affs.c and fat.c have a leftover
> grub_printf which I'll change to dprintf. In fat.c additionally printf
> is disabled). So I conclude that the consensus is not to have dprintfs
> in well-tested filesystem code.

I think you have a point, but perhaps it would be better to wait untill GRUB 2
reaches mainstream before removing debug information.  The average end user
doesn't know how to recompile GRUB, and getting distros to ship a new set of
binaries just for debug information isn't going to be possible.

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]