[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Crypto Review

From: Vladimir 'phcoder' Serbinenko
Subject: Re: Crypto Review
Date: Mon, 17 Aug 2009 20:28:41 +0200

On Mon, Aug 17, 2009 at 6:21 PM, Michael Gorven<address@hidden> wrote:
> On Monday 17 August 2009 18:07:07 Vladimir 'phcoder' Serbinenko wrote:
>> Diff would be nice. Because not all developpers (including me) are
>> familiar with bzr and it would take time for me to find out how to
>> request specifically the patch I want to review. Additionally not
>> posting diff makes inline reply impossible. It's fine to ask people to
>> test your bzr but for review patch is prefered.
> I attached diffs for three of the modules, since comments on the cipher/hash
> interface and style will affect all the modules and so I didn't see much
> point in reviewing all of them right now.
I agree. Just when I first read your mail I was under impression you
attached no patches and only then I noticed attached files. Sorry for
> If you'd like a diff of everything
> I can do that though.
> Michael
> --
> PGP Key ID 1E016BE8
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'phcoder' Serbinenko

Personal git repository:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]