[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GITGRUB] FB driver for EFI

From: Vladimir 'phcoder' Serbinenko
Subject: Re: [GITGRUB] FB driver for EFI
Date: Tue, 18 Aug 2009 20:02:35 +0200

+grub_uint32_t uga_fb;
+grub_uint32_t uga_pitch;
Why are these variables global? They should be either static or
properly prefixed.

Have you tried linux_video_setup as present in i386/linux.c in
i386/efi/linux.c ? It would be nice if we could share more code
between these 2 files. If it works and you judge that  i386/linux.c
and i386/efi/linux.c are similar enough you can merge them using
ifdef's when needed

Vladimir 'phcoder' Serbinenko

Personal git repository:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]