[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

From: Robert Millan
Subject: Re: [PATCH] Detect key modifier status in 'sleep --interruptible'
Date: Mon, 24 Aug 2009 00:56:23 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Why is it still asm? It can be done easily in C.
> Actually here we have 2 extremes: nice code (C, transform to nice
> flags (only one shift or 2 conrols and alts)) or small code (asm,
> crude value). Where we choose the compromise is a question for
> maintainer, not me.

Nice code, please.  We're pressed for space, but not *that* much.

Besides, we can't use this asm code as-is, unless we get word from the
people who wrote it (Colin wrote most of the patch, but not this).

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]