[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

From: Robert Millan
Subject: Re: [PATCH] Detect key modifier status in 'sleep --interruptible'
Date: Mon, 24 Aug 2009 15:27:11 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Aug 24, 2009 at 01:57:26PM +0200, Robert Millan wrote:
> On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote:
> > > But in at_keyboard it's definitely possible (check how we handle e.g. CTRL
> > > or SHIFT keys).
> > 
> > No, that code only spots make scan codes arriving after GRUB's terminal
> > starts up. AFAICS it has no way to tell whether e.g. Shift was held down
> > already when GRUB started
> Ah, you're right on this..
> > (except through the vagaries of key repeat),
> ..but on this too.  Why not check for key repeat?  The controller generates
> them for all keys AFAIK.

Or we could just make at_keyboard query the startup console for initial
state and then update it afterwards.

But this has the problem that in a multi-keyboard scenario we might be
using fake information.

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]