[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] zero-fill entry before asking BIOS for memory map

From: Robert Millan
Subject: Re: [PATCH] zero-fill entry before asking BIOS for memory map
Date: Thu, 3 Sep 2009 19:04:40 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Fri, Aug 28, 2009 at 09:21:02PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> >> +     /* clear the request area, buggy BIOSes may not clear it */
> >> +     xor     %edi, %edi
> >> +     movl    %edi, 4(%eax)
> >> +     movl    %edi, 8(%eax)
> >> +     movl    %edi, 12(%eax)
> >> +     movl    %edi, 16(%eax)
> >> +     movl    %edi, 20(%eax)
> >
> > This effectively hardcodes sizeof(entry).  Can we avoid it?
> Can one or another version be merge for release?

Pavel's point is right.  I don't like hardcoding sizeof(entry), but the
alternatives seem worse.

Please, could you at least add a comment to clarify that 20 aka sizeof(entry)
is implicit here ?

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]