[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch to replace (UUID=) hack

From: Vladimir 'phcoder' Serbinenko
Subject: Re: patch to replace (UUID=) hack
Date: Fri, 25 Sep 2009 13:31:54 +0200
User-agent: Mozilla-Thunderbird (X11/20090701)

Robert Millan wrote:
> On Tue, Sep 22, 2009 at 09:56:07AM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> Try attached WIP patch
> Excellent.  This was quite necessary.  I have to admit my (UUID=) kludge was
> a really poor solution (although in that time, the alternatives weren't
> so straightforwarded).
> I'm inclined to allow this for inclusion in 1.97, since it fixes a problem
> that could be seen as a bug (the overhead can be huge, specially in slow
> setups).
This patch isn't ready yet. grub-install has to be fixed for
grub-install for sparc64 too but I have no possibility to test it on
sparc64. I haven't tested it on multi-drive config on x86 yet.
>> -        prefix_drive="(UUID=${uuid})"
>> -        modules="$modules fs_uuid"
>> +        config="search_fs_uuid ${uuid} root"
>> +        modules="$modules search_fs_uuid"
> Note we don't need to explicitly include "root" there.  This would save 5
> bytes, and make the behaviour a bit more consistent (since root is
> implicit afterwards).

If "root" is omitted the found filename is printed on console

reply via email to

[Prev in Thread] Current Thread [Next in Thread]