[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Let user specify OpenBSD root device.
From: |
Robert Millan |
Subject: |
Re: [PATCH] Let user specify OpenBSD root device. |
Date: |
Fri, 16 Oct 2009 20:31:31 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Fri, Oct 16, 2009 at 01:00:31PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Vladimir 'phcoder' Serbinenko wrote:
> > On Wed, Aug 26, 2009 at 2:34 AM, Robert Millan<address@hidden> wrote:
> >
> >> On Tue, Aug 25, 2009 at 10:37:33PM +0200, Vladimir 'phcoder' Serbinenko
> >> wrote:
> >>
> >>> + if (cmd->state[OPENBSD_ROOT_ARG].set)
> >>> + {
> >>> + const char *arg = cmd->state[OPENBSD_ROOT_ARG].arg;
> >>> + int unit, part;
> >>> + if (*(arg++) != 'w' || *(arg++) != 'd')
> >>> + return grub_error (GRUB_ERR_BAD_ARGUMENT,
> >>> + "Only device specifications of form "
> >>> + "wd<number><lowercase letter> are supported.");
> >>> +
> >>> + unit = grub_strtoul (arg, (char **) &arg, 10);
> >>> + if (! (arg && *arg >= 'a' && *arg <= 'z'))
> >>> + return grub_error (GRUB_ERR_BAD_ARGUMENT,
> >>> + "Only device specifications of form "
> >>> + "wd<number><letter> are supported.");
> >>>
> >> Looks like the first error string could be used for both cases, saving
> >> a few bytes.
> >>
> >>
> This was fixed. Can this patch be comitted before release to avoid
> changing command syntax after release?
Ok.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."