grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add -nostdinc to TARGET_CFLAGS


From: Felix Zielcke
Subject: Re: [PATCH] Add -nostdinc to TARGET_CFLAGS
Date: Sun, 15 Nov 2009 12:19:42 +0100

Am Sonntag, den 15.11.2009, 12:12 +0100 schrieb Robert Millan:
> On Sun, Nov 15, 2009 at 12:04:58PM +0100, Robert Millan wrote:
> > On Sat, Nov 14, 2009 at 10:16:45PM +0100, Felix Zielcke wrote:
> > > Am Mittwoch, den 04.11.2009, 11:48 +0100 schrieb Felix Zielcke:
> > > > 
> > > > Thanks to the hint from rubisher I looked now at Linux Makefiles.
> > > > They use this:
> > > > 
> > > > NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) 
> > > > -print-file-name=include)
> > > > 
> > > > # ls $(gcc-4.4 -print-file-name=include)/stdarg.h
> > > > /usr/lib/gcc/x86_64-linux-gnu/4.4.2/include/stdarg.h
> > > > 
> > > 
> > > Robert?
> > > IMO this makes at least more sense then what we have now
> > > and I just tested this now with and without a seperate build directory
> > > with experimental branch and it works
> > > TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -nostdinc -isystem $(shell $(CC)
> > > -print-file-name=include) -I$(srcdir)/include -I$(builddir)
> > > -I$(builddir)/include -Wall -W
> > 
> > What's the advantage?
> 
> Ah, I remember.  There was a problem with stddef.h right?
> 
> So you propose something like this:
> 
> -TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -isystem=$(srcdir)/include 
> -I$(srcdir)/include -I$(builddir) -I$(builddir)/include \
> +TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -isystem=$(shell $(CC) 
> -print-file-name=include) -I$(srcdir)/include -I$(builddir) 
> -I$(builddir)/include \
> 
>   ?

See my previous mail, actually this:
-TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -isystem=$(srcdir)/include 
-I$(srcdir)/include -I$(builddir) -I$(builddir)/include \
+TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -nostdinc -isystem $(shell $(CC) 
-print-file-name=include) -I$(srcdir)/include -I$(builddir) 
-I$(builddir)/include \

The = in -isystem doestn't make much sense to me.
And with above -nostdinc really works for us.



-- 
Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer





reply via email to

[Prev in Thread] Current Thread [Next in Thread]