grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Just a cosmetic question about grub_vprintf()?


From: rubisher
Subject: Re: Just a cosmetic question about grub_vprintf()?
Date: Sat, 28 Nov 2009 18:21:20 +0000
User-agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109)

Robert Millan wrote:
On Sun, Nov 22, 2009 at 01:10:11PM +0000, rubisher wrote:
But as far as the 1st parameter of grub_vsprintf is a pointer,
wouldn't it be better to write:
--- kern/misc.c.orig    2009-11-22 13:07:22.000000000 +0000
+++ kern/misc.c 2009-11-22 13:07:51.000000000 +0000
@@ -160,7 +160,7 @@
 {
   int ret;

-  ret = grub_vsprintf (0, fmt, args);
+  ret = grub_vsprintf (NULL, fmt, args);
   return ret;
 }

Yes.  But we have many of those, so we don't go huntin' them.  If you'd
like to help us, a patch that does this change in bulk would be welcome.

Thanks

It will be of great pleasure for me, but I didn't foreseen so much (the most difficult to me are 'opaque pointer') but I hoppe that such 'sparse' would help me for the most ;<)

Hope to comeback soon,
        J.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]