[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] switch from sprintf to asprintf and snprintf

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] switch from sprintf to asprintf and snprintf
Date: Sun, 17 Jan 2010 13:02:55 +0100
User-agent: Mozilla-Thunderbird (X11/20091109)

Robert Millan wrote:
> On Fri, Jan 01, 2010 at 09:32:24AM +0000, Colin Watson wrote:
>> On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' 
>> Serbinenko wrote:
>>> +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...)
>>> +     __attribute__ ((format (printf, 1, 2)));
>> It's very confusing that you've made grub_asprintf have a dramatically
>> different interface from asprintf. Perhaps you could call this
>> grub_xasprintf instead?
> Is it feasible to implement the same interface as asprintf instead?
it's feasible but the only advantage it gives is the return value nobody
uses anyway

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]