[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gfxmenu relative path in "file" component of images

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] gfxmenu relative path in "file" component of images
Date: Wed, 20 Jan 2010 23:51:05 +0100
User-agent: Mozilla-Thunderbird (X11/20091109)

Robert Millan wrote:
> This makes it possible to use relative paths in the "file" component of
> gfxmenu images.  I've tested that it works, but I'd appreciate if someone
> more familiar with gfxmenu can review it.

+  static const char *theme_dir = NULL;
Add a member to grub_gui_image_t rather than using a static variable

+      theme_dir = value;
Use appropriate grub_strdup and free in _destroy function.
+      return load_image (self, absvalue);
absvalue isn't freeed

> ------------------------------------------------------------------------
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]