Re: beep support?

[Vladimir 'φ-coder/phcoder' Serbinenko]

Samuel Thibault wrote:
> Samuel Thibault, le Fri 05 Feb 2010 19:11:18 +0100, a écrit :
>   
>> Vladimir 'φ-coder/phcoder' Serbinenko, le Fri 05 Feb 2010 17:52:02 +0100, a 
>> écrit :
>>     
>>> Could you detail at which events beep should be produced and propose a
>>> patch to add appropriate hooks?
>>>       
>> A beep just when the menu is first drawn is already a good thing and is
>> trivial to add by just calling play in the main menu.
>>     
>
> Here is a proposed patch.  Is the GRUB_INIT_TUNE variable name Ok?
>
>   
This is small clean patch and it improves accessibility. Please go ahead.
> Samuel
>
> 2010-02-14  Samuel Thibault  <address@hidden>
>
>       * util/grub-mkconfig.in: Export GRUB_INIT_TUNE.
>       * util/grub.d/00_header.in: Handle GRUB_INIT_TUNE.
>
> --- util/grub-mkconfig.in     2010-02-10 18:53:13 +0000
> +++ util/grub-mkconfig.in     2010-02-14 18:05:11 +0000
> @@ -222,7 +222,8 @@ export GRUB_DEFAULT \
>    GRUB_GFXMODE \
>    GRUB_THEME \
>    GRUB_GFXPAYLOAD_LINUX \
> -  GRUB_DISABLE_OS_PROBER
> +  GRUB_DISABLE_OS_PROBER \
> +  GRUB_INIT_TUNE
>  
>  if test "x${grub_cfg}" != "x"; then
>    rm -f ${grub_cfg}.new
>
> === modified file 'util/grub.d/00_header.in'
> --- util/grub.d/00_header.in  2010-02-03 00:24:07 +0000
> +++ util/grub.d/00_header.in  2010-02-14 17:55:04 +0000
> @@ -158,3 +158,11 @@ else
>  set timeout=${GRUB_TIMEOUT}
>  EOF
>  fi
> +
> +# Play an initial tune
> +if [ "x${GRUB_INIT_TUNE}" != "x" ] ; then
> +  cat << EOF
> +insmod play
> +play ${GRUB_INIT_TUNE}
> +EOF
> +fi
>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature