[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH][UPDATED] support for xz compression format

From: Szymon Janc
Subject: Re: [PATCH][UPDATED] support for xz compression format
Date: Tue, 16 Feb 2010 14:27:05 +0100

On Tue, 16 Feb 2010 14:12:04 +0100  Vladimir 'φ-coder/phcoder' Serbinenko 
<address@hidden> wrote

> First of all: could you use unified diff? (-u option)

Sure, will use that in future.

> grub2-1.98~experimental.20100120/conf/xzembed.rmk
> I don't see a need for either separate .rmk or separate module
> + static grub_uint8_t inbuf[XZBUFSIZ];
> + static grub_uint8_t outbuf[XZBUFSIZ];
> Avoid static variables. It will fail if user e.g. mounts xz file as a
> loopback then opens xz'ed file on this loopback. Just put buffers in
> grub_xzio
> +   if (! file)
> +   {
> +       grub_error (GRUB_ERR_OUT_OF_MEMORY, "out of memory");
> +     return 0;
> grub_error is already issued by grub_malloc, no need to put the same
> code here.

I think You have reviewed old patch, not the updated one :-)

Szymon Janc

reply via email to

[Prev in Thread] Current Thread [Next in Thread]