[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] transparent file reader

From: Szymon Janc
Subject: Re: [PATCH] transparent file reader
Date: Tue, 16 Feb 2010 20:12:56 +0100
User-agent: KMail/1.12.4 (Linux/2.6.32-trunk-686; KDE/4.3.4; i686; ; )

Dnia wtorek 16 luty 2010 o 19:16:19 Vladimir 'φ-coder/phcoder' Serbinenko 

> I like the patch however few comments:
> 1) How are filters ordered?

Filters are tested in order that last registered filter is tested first. First 
match stop further tests.

> 2) How would I selectively disable a filter. E.g. for hexdump or when
> payload expects compressed data?

Currently one would have to unregister filters before calling grub_file_open()
and reregister them afterwards. However this can mix up filters order. Not 
a best option.

I was thinking about something like:
grub_file_open("name", NO_XFILTER|NO_YFILTER);
to allow selectable filters or fopen() style maybe.

And a priority based filter registration if there is a need for that.

Szymon K. Janc
address@hidden // GG: 1383435

reply via email to

[Prev in Thread] Current Thread [Next in Thread]