[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

escape strings in grub.cfg

From: Carles Pina i Estany
Subject: escape strings in grub.cfg
Date: Sat, 10 Apr 2010 22:10:15 +0100
User-agent: Mutt/1.5.20 (2009-06-14)


Last weekend, the Asturian team found a bug in Grub. Thanks for the
debugging. The string that appears in grub.cfg for "Loading the initram"
in Asturian is "Cargando'l discu RAM inicial...". So grub.cfg looks
        echo    Cargando'l discu RAM inicial...

This is syntactically invalid because the character "'".

Easy work around: generate the line like:
        echo    "Cargando'l discu RAM inicial..."

New problem: in some language, this string could have a double quote

New solution: escape the double quotes strings when they are used in
gettext and always use these strings with double quotes.

See the attached patch.

I'm not convinced of the patch, does anybody has a cleaner idea/patch?


PS: I haven't double checked, but lines like initrd  
/boot/initrd.img-2.6.32-18-generic will fail if the path has spaces. I'll 
address it in the future.

PS2: I haven't checked the patch yet, let's comment on the idea. Before
committing I would write the changelog and check it.

Carles Pina i Estany

Attachment: gettext_double_quotes.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]