grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Function parameters support


From: Seth Goldberg
Subject: Re: [PATCH] Function parameters support
Date: Wed, 5 May 2010 10:36:43 -0700 (PDT)
User-agent: Alpine 2.00 (GSO 1167 2008-08-23)

Hi!

Quoting BVK Chaitanya, who wrote the following on Wed, 5 May 2010:

Hi,


Attached patch adds function parameters ($1, $2, etc. and $#) support
to GRUB script..  Shell expansion for "$@" and $@ specials is not yet
available.

This is a *great* start, but can you please add support for $* as well as a shift operator (though shift is not as useful when there are no looping constructs) so I can do something like this:

function old_multiboot {
  multiboot $1 $*
  # or
  kern=$1
  shift
  multiboot $kern $kern $*
}

(This duplicates the first argument, important for booting multiboot kernels that need to see the name of the multiboot kernel file).

Also: Do you think there's value in supporting $0, where that expands to the function name?

 Thanks!
 --S




reply via email to

[Prev in Thread] Current Thread [Next in Thread]