[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Use absolute offset for embedding area in grub-setup (i386-p

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [Patch] Use absolute offset for embedding area in grub-setup (i386-pc)
Date: Mon, 07 Jun 2010 22:48:06 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100515 Icedove/3.0.4

On 06/05/2010 02:22 AM, Grégoire Sutre wrote:

The attached patch uses grub_partition_get_start (p) instead of p->start
in grub-setup's iteration over partitions.  While we are at it, also
use grub_partition_get_len (p) instead of p->len.
Go ahead

An alternative would be to assume that partitions are properly nested,
and therefore iterate only over the top-level ones (i.e. those with
p->parent == NULL).  In that case, we could equivalently use p->start.

In the check for non-empty embedding area, the patch uses <= instead of
== (as we may have embed_region.start == 1 && embed_region.end == 0).


_______________________________________________ Grub-devel mailing list address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]