[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug in multiboot_mbi2.c

From: Seth Goldberg
Subject: Re: Bug in multiboot_mbi2.c
Date: Mon, 21 Jun 2010 19:26:03 -0700 (PDT)
User-agent: Alpine 2.00 (GSO 1167 2008-08-23)

BTW, while we're at it, we can remove the redundant tag->common.framebuffer_type assignment :).


Quoting Seth Goldberg, who wrote the following on Mon, 21 Jun 2010:

The code that constructs the framebuffer info has a nasty bug where the field position and mask size for red are set to the GREEN values:

     tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB;
     tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB;
-->   tag->framebuffer_red_field_position = mode_info.green_field_pos;
-->   tag->framebuffer_red_mask_size = mode_info.green_mask_size;
     tag->framebuffer_green_field_position = mode_info.green_field_pos;
     tag->framebuffer_green_mask_size = mode_info.green_mask_size;
     tag->framebuffer_blue_field_position = mode_info.blue_field_pos;
     tag->framebuffer_blue_mask_size = mode_info.blue_mask_size;


Grub-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]