[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFT] Re: [Patch] [bug #26237] multiple problems with usb devices

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [RFT] Re: [Patch] [bug #26237] multiple problems with usb devices
Date: Fri, 25 Jun 2010 20:10:59 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100515 Icedove/3.0.4

> Hi Vladimir,
> now I have working SSH, so I committed my last work into usb branch
> (commented as "Faster OHCI, USB hub support, UHCI portstatus corr.",
> revision 2427).
> (Sorry if it is not the right way how to cooperate - should I make
> another, my own branch? Or wait first for your agreement about notified
> patches? Or...?)
It's the right way. If something is in branches/ as opposed to personal
directory it means that every dev is welcome to commit but it's highly
recommended to be present at IRC at the moment of commit and ping
original author if he's only too. The only exception is experimental
branch which is reviewed.
If you want more comments on your changes please send patches to ML
> Best regards
> Ales
>> Hi Vladimir,
>> one more idea:
>> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> Hello, Aleš. Today I merged usb branch into mainline. Now I've started
>>> some work towards hotplugging and module autoloading. Currently it just
>>> checks portsstatus to see newly connected devices. Touble is that if you
>>> disconnect a device and plug a new one at its place this routine won't
>>> notice anything because ports are polled only when enumerating
>>> usbdevices. We need a more reliable way to detect new devices. Perhaps
>>> we should try to assign addresses to any device without address and see
>>> if it responds to configuration request. If noone responds assume that
>>> no devices were newly connected.
>>> On Yeeloong 'usb' command lists hotplugged devices correctly but bulk
>>> transfer fails with donehead=0.
>> It can be result of bad toggling. If device does not accept
>> configuration, it does not reset toggle bits in its bulk endpoints.
>> But function grub_usb_set_configuration does reset of toggle bits in any
>> case. Perhaps function grub_usb_set_configuration should reset toggling
>> only if configuration is accepted by device.
>> Best regards
>> Ales
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]