[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gfxterm/pager regression

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: gfxterm/pager regression
Date: Tue, 06 Jul 2010 02:06:47 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100620 Icedove/3.0.5

On 07/05/2010 02:47 PM, Colin Watson wrote:
> gfxterm is behaving very oddly for me with 'set pager=1' right now; the
> --MORE-- prompt appears after only a few lines of text have been output.
> It looks rather as if it is counting the number of output characters as
> if they were the number of output lines.  This doesn't happen when the
> terminal output is an ordinary VGA console.
> Looking at normal/term.c:put_glyphs_terminal, it seems that it
> increments state->num_lines after every glyph.  This seems pretty odd.
> Doesn't it need to do something a bit smarter than that?  Vladimir, is
> this a regression from your bidi branch merge?
Looks this way. Please test attached patch.
> Thanks,

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: charnl.diff
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]