[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] File name transformations (split into 7 diffs)

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] File name transformations (split into 7 diffs)
Date: Wed, 21 Jul 2010 07:11:37 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100620 Icedove/3.0.5

On 06/04/2010 01:42 AM, Grégoire Sutre wrote:
> +pkglibrootdir=${libdir}/`echo ${PACKAGE_TARNAME} | sed 
> "${program_transform_name}"`
> +
> +case "$host_os" in
> +netbsd* | openbsd*)
> +    # Because /boot is used for the boot block in NetBSD and OpenBSD, use 
> /grub
> +    # instead of /boot/grub.
> +    defaultbootdir=
> +    ;;
> +*)
> +    # Use /boot/grub by default.
> +    defaultbootdir=/boot
> +    ;;
> +esac
/boot isn't transformed

+    # XXX hard-coded /boot (use ${grubdir} or ${defaultbootdir} ?)
     $grub_mkimage ${config_opt} -f ${font} -d ${pkglibdir} -O 
${mkimage_target} --output=/boot/grub.elf 
--prefix=${prefix_drive}${relative_grubdir} $modules || exit 1

Should have been ${grubdir}/grub.elf

+    # XXX hard-coded /boot (use ${grubdir} or ${defaultbootdir} ?)
     $grub_mkimage -O ${mkimage_target} ${config_opt} -d ${pkglibdir} 
--output=/boot/multiboot.img --prefix=${prefix_drive}${relative_grubdir} 
$modules || exit 1


+# GRUB_DIR should be set before sourcing this file, but let's be safe.
+if test "x${GRUB_DIR}" != "x"; then
+  if test -e "${GRUB_DIR}/"; then
+    grub_probe="${grub_probe} --device-map=${GRUB_DIR}/"
+  fi
This would be a separate patch and the problem is that scripts assume that 
currently loaded kernel is the kernel which will be loaded or similar (look 
e.g. at uuid check). This would be a separate patch.

go ahead for trunk


go ahead for trunk


Transforming names in manual may be cumbersome and conflicts with Colin's patch.


-         $(INSTALL_DATA) $$dir$$file 
$(DESTDIR)/$(datadir)/locale/$$lang/LC_MESSAGES/$(PACKAGE).mo; \
+         dest="`echo $(PACKAGE).mo | sed 's,.*/,,' | sed '$(transform)'`"; \
+         $(INSTALL_DATA) $$dir$$file 
$(DESTDIR)$(datadir)/locale/$$lang/LC_MESSAGES/$$dest; \
Why don't you transform locale and LC_MESSAGES?


Go ahead for trunk

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]