[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add grub_dcprintf for continuations without file/line

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Add grub_dcprintf for continuations without file/line
Date: Wed, 28 Jul 2010 17:42:36 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100620 Icedove/3.0.5

On 07/25/2010 06:09 AM, Josh Triplett wrote:
> The attached patch adds a new variant of grub_dprintf, grub_dcprintf,
> which avoids printing the __FILE__:__LINE__: prefix.  This allows
> printing a single line with multiple print statements; for instance:
> grub_dprintf("some_module", "Thingy: ");
> print_complicated_thingy(thingy);
> grub_dcprintf("some_module", ", more details here\n");
> Without the dcprintf variant, this line will contain three different
> file/line prefixes.
> I also added support for a "no-file-line" token in the debug environment
> variable, which turns off the file/line prefixes entirely.
core is very size sensitive. You need a valid usecase to justify such a
feature in it. It feels like useful only for dumping a mass of info. In
practice users can only report back around 4-5 lines, sometimes a
compelete screen by taking its picture, so this info would be lost in
bugreports anyway. If you're developping something you usually need a
dump in that exact place only once and then using grub_printf is usually
> - Josh Triplett
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]