[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ACPI halt failures in tests

From: Colin Watson
Subject: ACPI halt failures in tests
Date: Tue, 23 Nov 2010 15:29:37 +0000
User-agent: Mutt/1.5.18 (2008-05-17)

I occasionally get "ACPI shutdown failed" in qemu during tests.  Since
this is printed with grub_printf rather than with grub_dprintf or
whatever, it shows up in the test output and causes tests to fail.  It
only fails some of the time on my system (less than half).  I've tried
to insert 'set debug=acpi' into the grub-shell test setup, but it
stubbornly succeeds when I do that, so I'm not really sure what else to

The system seems to shut down happily anyway, presumably because it goes
on to try other boot methods.  Should we maybe downgrade this to a debug

I've only seen this on Ubuntu, not on Debian, but I have no idea what's
different about our qemu packaging.

2010-11-23  Colin Watson  <address@hidden>

        * grub-core/commands/acpihalt.c (grub_acpi_halt): Downgrade "ACPI
        shutdown failed" to a debug message, since it can cause spurious
        test failures.

=== modified file 'grub-core/commands/acpihalt.c'
--- grub-core/commands/acpihalt.c       2010-10-16 18:01:30 +0000
+++ grub-core/commands/acpihalt.c       2010-11-23 15:27:41 +0000
@@ -324,6 +324,6 @@ grub_acpi_halt (void)
-  grub_printf ("ACPI shutdown failed\n");
+  grub_dprintf ("acpi", "ACPI shutdown failed\n");


Colin Watson                                       address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]