Re: [PATCH] MINIX file system version 3 support

[Fam Cook]

As I've done the assignment of contributor copyright with FSF, I'd
like to send this patch here once more, as introduced in quoting, it's
for MINIX3 FS support. Already updated based on the latest trunk code,
please check and notify me if more adjust needed.

2010/9/8 Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden>:
> On 07/28/2010 05:25 AM, Fam Zheng wrote:
>> Hi,
>>
>> To support MINIX file system version 3, this patch adds a new module
>> named 'minix3'. It reuses most of the code in minix.mod, and handles
>> the latest MINIX file system version 3.
>>
>> The requested assignment information has also been sent to
>> address@hidden <mailto:address@hidden>.
>>
> Please, ensure that patches have correct mime type. It's annoying to
> have to save them separately just to view.
>   struct grub_minix_inode inode;
>   struct grub_minix2_inode inode2;
> +#ifdef GRUB_MOD_MINIX3
> inode and inode2 shouldn't be present in minix3 structure.
>
> +static unsigned int blocksize;
> +
> All FS info must be in _data structure. Otherwise 2 simultaneously
> mounted filesystems will conflict.
> +#ifdef GRUB_MOD_MINIX3
> +  first_dbl_indir=indir_capacity+7;
> +  if (blk < first_dbl_indir)
> +    {
> +      blk -= 7;
> +      indir = grub_get_indir (GRUB_MINIX_INODE_INDIR_ZONE (data), blk);
> +      return indir;
> +    }
> +#else
> Where does 7 come from? It must be macroified.
>
> +  if(ino==0) return GRUB_ERR_BAD_ARGUMENT;
> must be 2 lines and return should be return grub_error (GRUB_ERR_BAD_FS,
> "incorrect inode");
> +#define GRUB_MOD_MINIX3
> +#include "minix.c"
> It should be MODE_MINIX3
> I'm now splitting minix.mod into minix.mod nd minix2.mod, once I'm
> finished please adjust your patch
> --
>> Best Regards!
>> Fam Zheng
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
> --
> Regards
> Vladimir 'φ-coder/phcoder' Serbinenko
>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



--
Best regards!
Fam Zheng