[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #61

From: Alexander Kurtz
Subject: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417)
Date: Tue, 05 Apr 2011 14:55:07 +0200


currently you can't use an image which has whitespace in its filename as
GRUB background image because grub-mkconfig_lib lacks proper variable
quoting (see [1] for more information). I've attached three patches
which should fix this problem:

  This patch fixes the problem with the minimal set of changes.

  This patch adds proper quoting wherever it is safe to do so.

  This patch additionally adds quoting in cases like this:
   ${grub-probe} --foo --bar => "${grub-probe}" --foo --bar
  This breaks things if ${grub-probe} contains additional parameters.

Please note that I already submitted similar patches a while ago[2], but
these are a little outdated now. The attached patches have been
refreshed and should apply cleanly to the current trunk.

What do you think?

Best regards

Alexander Kurtz


Attachment: quote-small.patch
Description: Text Data

Attachment: quote-medium.patch
Description: Text Data

Attachment: quote-big.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]