[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417)
Date: Fri, 08 Apr 2011 15:44:33 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110402 Iceowl/1.0b2 Icedove/3.1.9

On 06.04.2011 17:31, Alexander Kurtz wrote:
> Am Dienstag, den 05.04.2011, 23:27 +0200 schrieb Nicolas de Pesloüan:
>> Le 05/04/2011 22:53, Colin Watson a écrit :
>>> On Unix-like systems, though, and particularly when it comes to shell,
>>> this often involves knowing about historical behaviour as well as
>>> current behaviour.
>> Thanks Colin, for clarifying this!!
>> Very appreciated.
> Now that we've all learned something new again (at least I have ;-) ),
> let's go back to the main topic:
> What do you think of the patch itself?
The (big) patch is mostly fine except:
-Please don't add brances where not needed
-Please don't add quoting to constants like x since x or "x" are
strictly identical.
> Best regards
> Alexander Kurtz
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]