grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] EHCI driver - USB 2.0 support


From: Philipp Hahn
Subject: Re: [PATCH] EHCI driver - USB 2.0 support
Date: Thu, 3 Nov 2011 10:25:23 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Hello,

I had a look at your EHCI driver, while investigating why grub-1.99
needs 2 minutes to load my 58 MB InitRd.

On Sat, Aug 27, 2011 at 06:42:18PM +0200, AleŇ° Nesrsta wrote:
> Changes in other files are still the same (more precisely, I hope - I
> didn't check if there are some other unrelated changes from anybody else
> in newest trunk revision...) - usb_ehci_110625_0.

Compiling on x86_86 failed for me in grub-core/bus/usb/usbhub.c:104

>  grub_dprintf ("usb", "Added new usb device: %08x, addr=%d\n",
>    (grub_uint32_t)dev, i);

because dev is a 64 bit pointer which GCC didn't like to cast to an
uint32 with the compiler options used by Debian. I fixed this locally by
changing those two lines to use '%p' instead of '%08x' and without the
cast:

  grub_dprintf ("usb", "Added new usb device: %p, addr=%d\n",
    dev, i);

Even without that I wasn't able to get EHCI working: If I insmod 'usbms'
and 'ehci', no disk is detected. Only when I insmod 'ohci' is the stick
detected. With 'set debug=ehci pager=1' I get some lines, before the
screen is spammed with 'STATUS'-lines and the computer reboots.
Did I miss something obvious or can I help debug this?

Sincerely
Philipp
-- 
Philipp Hahn           Open Source Software Engineer      address@hidden
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]