[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enable install of grub2 in PReP partition

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Enable install of grub2 in PReP partition
Date: Fri, 11 Nov 2011 16:11:17 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20111010 Iceowl/1.0b2 Icedove/3.1.15

On 11.11.2011 15:02, Paulo de Rezende Pinatti wrote:
> +      if (dev->disk->partition == NULL)
> +        {
> +          grub_util_info ("no partition map found for %s", dev->disk->name);
> +        }
> +
> +      if (strcmp(dev->disk->partition->partmap->name, "msdos") == 0)
This is wrong, you check for the pointer being non-NULL, issue a warning
and then happily dereference it regardless.

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]