Re: Lists and aliasing (Re: Freeze on 27 February)

[Lennart Sorensen]

On Wed, Feb 22, 2012 at 08:00:54PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko 
wrote:
> Alternative is to add a condition which will ensure the loop
> termination but don't interfere with it other wise by using the fact
> that min (UINT_MAX, r)=r if r is unsigned int.
> 
> 
> -- 
> Regards
> Vladimir 'φ-coder/phcoder' Serbinenko
> 

> === modified file 'conf/Makefile.common'
> --- conf/Makefile.common      2012-02-22 15:27:39 +0000
> +++ conf/Makefile.common      2012-02-22 17:26:03 +0000
> @@ -104,7 +104,7 @@
>  CFLAGS_GCRY = -Wno-error -Wno-missing-field-initializers
>  CPPFLAGS_GCRY = -I$(top_srcdir)/grub-core/lib/libgcrypt_wrap
>  
> -CFLAGS_GNULIB = -Wno-undef -Wno-sign-compare -Wno-unused 
> -Wno-unused-parameter -Wno-redundant-decls -Wno-unreachable-code 
> -Wno-conversion -Wno-old-style-definition
> +CFLAGS_GNULIB = -Wno-undef -Wno-sign-compare -Wno-unused 
> -Wno-unused-parameter -Wno-redundant-decls -Wno-unreachable-code 
> -Wno-conversion -Wno-old-style-definition -Wno-unsafe-loop-optimizations
>  CPPFLAGS_GNULIB = -I$(top_builddir)/grub-core/gnulib 
> -I$(top_srcdir)/grub-core/gnulib
>  
>  CFLAGS_POSIX = -fno-builtin
> 
> === modified file 'configure.ac'
> --- configure.ac      2012-02-22 03:56:45 +0000
> +++ configure.ac      2012-02-22 16:51:06 +0000
> @@ -377,9 +377,9 @@
>  LIBS=""
[snip]

Now I get:

gcc-4.6 -DHAVE_CONFIG_H -I. -I../../../grub-core -I..  -Wall -W 
-I../../../include -I../include  -DGRUB_MACHINE_EMU=1 
-DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 -m32 
-DGRUB_FILE=\"normal/charset.c\" -I. -I../../../grub-core -I.. -I../../.. 
-I../../../include -I../include   -I../../../grub-core/lib/posix_wrap   -Os 
-Wall -W -Wshadow -Wold-style-declaration -Wold-style-definition 
-Wpointer-arith -Wundef -Wextra -Waddress -Warray-bounds -Wattributes 
-Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment 
-Wcoverage-mismatch -Wdeprecated -Wdeprecated-declarations 
-Wdisabled-optimization -Wdiv-by-zero -Wempty-body -Wendif-labels -Wfloat-equal 
-Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k 
-Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration -Wimplicit-int 
-Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wunsafe-loop-optimizations 
-Wlogical-op -Wmain -Wmissing-braces -Wmissing-field-initializers 
-Wmissing-format-attribute -Wmissing-noreturn -Wmudflap -Wmultichar -Wnonnull 
-Woverflow -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith 
-Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare 
-Wstrict-aliasing -Wswitch -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef 
-Wuninitialized -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label 
-Wunused-parameter -Wunused-value  -Wunused-variable -Wvariadic-macros 
-Wvolatile-register-var -Wwrite-strings -Wmissing-parameter-type 
-Wnested-externs -Wstrict-prototypes -Wpointer-sign -g -Wredundant-decls 
-Wmissing-prototypes -Wmissing-declarations -fno-dwarf2-cfi-asm 
-fno-asynchronous-unwind-tables -m32 -fno-stack-protector -Werror 
-Wno-trampolines -DUSE_ASCII_FAILBACK=1 -DHAVE_UNIFONT_WIDTHSPEC=1         
-ffreestanding -fno-builtin -Wno-redundant-decls   -c -o 
normal/normal_module-charset.o `test -f 'normal/charset.c' || echo 
'../../../grub-core/'`normal/charset.c
../../../grub-core/normal/charset.c: In function 'bidi_line_wrap':
../../../grub-core/normal/charset.c:737:55: error: comparison between signed 
and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

-- 
Len Sorensen