[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix crash on http
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] Fix crash on http |
Date: |
Fri, 01 Feb 2013 21:55:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11 |
On 27.09.2012 19:55, Gustavo Luiz Duarte wrote:
>
> Don't free file->data on receiving FIN flag since it is used all over without
> checking. http_close() will be called later to free that memory.
> Downstream bug: http://bugzilla.redhat.com/show_bug.cgi?id=860834
This patch of not just freeing fixes one instance of a more general
problem. Please try the attached patch
> ---
> grub-core/net/http.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/net/http.c b/grub-core/net/http.c
> index a7542d1..a5f6f31 100644
> --- a/grub-core/net/http.c
> +++ b/grub-core/net/http.c
> @@ -386,7 +386,7 @@ http_establish (struct grub_file *file, grub_off_t
> offset, int initial)
>
> data->sock = grub_net_tcp_open (file->device->net->server,
> HTTP_PORT, http_receive,
> - http_err, http_err,
> + http_err, NULL,
> file);
> if (!data->sock)
> {
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
http.diff
Description: Text Data
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] Fix crash on http,
Vladimir 'φ-coder/phcoder' Serbinenko <=