[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove nested functions from disk and file read hooks

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Remove nested functions from disk and file read hooks
Date: Tue, 26 Feb 2013 22:57:40 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 21.01.2013 13:14, Colin Watson wrote:

> Part seven.  This particular patch in the set loses some of the
> compressed-kernel size we'd gained from earlier patches, but it's still
> a good bit smaller than when I started on this work so I'm not worried.
> Note that, as a general pattern, I have intentionally not zeroed out
> read_hook_data after calling code using a read hook; this is because (a)
> the code that calls read hooks only checks whether read_hook is NULL,
> (b) every function that sets read_hook to something non-NULL naturally
> also sets read_hook_data if it cares about its value, and (c) avoiding
> the extra code to zero read_hook_data makes a few bytes of difference to
> the size of compressed core images.

There are some possible improvements that we've discussed on IRC.
Apparently you didn't have time to implement them. They can come in
separately later if needed. Go ahead.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]