grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gfxterm: check elements' properties and hadle errors.


From: Vladimir Testov
Subject: Re: [PATCH] gfxterm: check elements' properties and hadle errors.
Date: Thu, 07 Mar 2013 11:46:15 +0400
User-agent: KMail/4.9.4 (Linux/3.5.0-23-generic; KDE/4.9.4; x86_64; ; )

>This is not a correct error handling. You should never return an error
>without calling grub_error. Also in all these contexts you handle the
>cases of unknown property name. I don't feel like refusing to load a
>theme because of unknown property is a good idea. This would i.a.
>exclude older GRUB versions for newer themes even if property in
>question is minor in meaning. Compare this to a browser refusing to show
>a page because of unknown tag attribute. Also GRUB_ERR_IO hardly
>describes a condition of unknown property.
Thanks for the reply. :) This subject is closed.

--

With best regards,

_______________________________

Vladimir Testov, ROSA Laboratory.

www.rosalab.ru


reply via email to

[Prev in Thread] Current Thread [Next in Thread]