[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] missed grub_free in icon_manager

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] missed grub_free in icon_manager
Date: Thu, 07 Mar 2013 10:05:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 07.03.2013 09:53, Vladimir Testov wrote:

>        icondir = grub_env_get ("icondir");
>        if (icondir)
>       icon = try_loading_icon (mgr, icondir, class_name);
> +      grub_free(icondir);

grub_env_get doesn't give you a personal copy but the common one. You
should not free it. In fact it should have been declared as returning
const char *.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]