[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] multistring support in gui_label

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] multistring support in gui_label
Date: Wed, 03 Apr 2013 09:20:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12

On 22.03.2013 16:58, Vladimir Testov wrote:

> +    word_width = label_string_width (buf, font, l_lastend, end);
> +    if (isvertical || (str_width + word_width > l_width)) // can't add new 
> word
> +      {

Please don't use // comments. This code completely forgets the cases
when even the first word doesn't fit in the available space.
The code as whole breaks some unicode concepts like e.g. bidi stack.
Could you reuse the already available line-vreaking algorithm in
normal/term.c and normal/charset.c ? Since the line-breaking is
artificially disabled for labels it should require only minor
adjustments to be reenabled.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]