[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] Fix reporting of RAIDZ vdevs in zfsinfo

From: Massimo Maggi
Subject: Re: [PATCH 1/5] Fix reporting of RAIDZ vdevs in zfsinfo
Date: Mon, 06 May 2013 23:03:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130505 Thunderbird/17.0.5

Nella citazione in data lun 06 mag 2013 20:10:13 CEST, Vladimir
'φ-coder/phcoder' Serbinenko ha scritto:
> I meant other patches as well. Can you resend them as attachements?
Yes, you can find them attached to this message.

However I should warn you that few days ago some users have found that
the patch number 3 causes an infinite loop in grub2-probe when probing
non-ZFS partitions.
The problem is not easily reproducible and is being tracked on:

I have an hypotesis about the problem (and corresponding fix), but I
need feedback from users in order to be sure that I've catched it.
Richard Yao found a workaround for this problem by reverting part of the
patch 3 "Refactoring of function nvlist_find_value", that I've ported
from IllumOS in order to keep the code as similar as possible (to ease
ports of future ZFS features).

There is also a minor cosmetic issue, as in patch 4 I've mistakenly left
a bogus feature, that gets removed by patch 5.

When the issue about the infinite loop gets fully understood and fixed,
I'll send an updated set of patches.
What do you think about excluding the refactoring of nvlist_find_value
and keeping the codebase of ZFS in Grub2 less consistent with ZFS in
Grub1/IllumOS where AFAIK new features are primarily developed?

Massimo Maggi

Attachment: 0001-Fix-reporting-of-RAIDZ-vdevs-in-zfsinfo.patch
Description: Text Data

Attachment: 0002-Accept-pool-version-5000-for-feature-flags.patch
Description: Text Data

Attachment: 0003-Refactoring-of-function-nvlist_find_value.patch
Description: Text Data

Attachment: 0004-Check-for-feature-flags-needed-to-read-from-the-pool.patch
Description: Text Data

Attachment: 0005-LZ4-compression-in-ZFS.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]