[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] restore -nostdlib for libgcc symbols tests
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] restore -nostdlib for libgcc symbols tests |
Date: |
Sat, 16 Nov 2013 13:51:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 |
On 16.11.2013 05:49, Andrey Borzenkov wrote:
>> -static shouldn't create problems. Adding -nostdlib like I proposed
>> should solve the problem.
>
> Right, it was fallout of "plug the leakage" patch. I think below
> patch is more aligned with the rest of code.
>
> Commit 24f4e57c4684471da088c504dec0380886eece0c plugged leakage
> of CFLAGS between individual tests, which broke test for libgcc
> symbols. It needs -nostdlib which was set in previous test and
> inherited before. Set it explicitly.
>
Go ahead
> ---
> configure.ac | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 2c4f019..1842910 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -815,9 +815,9 @@ LIBS="$TARGET_LIBGCC"
> grub_ASM_USCORE
> if test "x$TARGET_APPLE_LINKER" = x0 ; then
> if test x$grub_cv_asm_uscore = xyes; then
> -CFLAGS="$TARGET_CFLAGS -Wl,--defsym,_abort=_main"
> +CFLAGS="$TARGET_CFLAGS -nostdlib -Wl,--defsym,_abort=_main"
> else
> -CFLAGS="$TARGET_CFLAGS -Wl,--defsym,abort=main"
> +CFLAGS="$TARGET_CFLAGS -nostdlib -Wl,--defsym,abort=main"
> fi
> fi
>
>
signature.asc
Description: OpenPGP digital signature
- PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Andrey Borzenkov, 2013/11/15
- Re: PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Vladimir 'φ-coder/phcoder' Serbinenko, 2013/11/15
- Re: PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Andrey Borzenkov, 2013/11/15
- Re: PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Vladimir 'φ-coder/phcoder' Serbinenko, 2013/11/15
- Re: PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Andrey Borzenkov, 2013/11/15
- Re: PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Vladimir 'φ-coder/phcoder' Serbinenko, 2013/11/15
- Re: PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Andrey Borzenkov, 2013/11/15
- Re: PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Vladimir 'φ-coder/phcoder' Serbinenko, 2013/11/15
- Re: PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, ..., Andrey Borzenkov, 2013/11/15
- [PATCH] restore -nostdlib for libgcc symbols tests, Andrey Borzenkov, 2013/11/15
- Re: [PATCH] restore -nostdlib for libgcc symbols tests,
Vladimir 'φ-coder/phcoder' Serbinenko <=